Skip to content

kernel: T9138: enable support for Microsoft MANA NIC driver - #1254

Merged
dmbaturin merged 1 commit into
vyos:rollingfrom
dmbaturin:T9138-azure-mana
Jul 28, 2026
Merged

kernel: T9138: enable support for Microsoft MANA NIC driver#1254
dmbaturin merged 1 commit into
vyos:rollingfrom
dmbaturin:T9138-azure-mana

Conversation

@dmbaturin

@dmbaturin dmbaturin commented Jul 28, 2026

Copy link
Copy Markdown
Member

Change summary

MANA (Microsoft Azure Network Adapter) is a paravirtual NIC type used by Azure that requires its own kernel module. This PR enabled building the module that previously wasn't in our config.

The module only supports x86 at the moment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@coderabbitai

coderabbitai Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f98c05e4-dae2-4386-979f-b335282a9fe2

📥 Commits

Reviewing files that changed from the base of the PR and between e8fd5d2 and caa1f3f.

📒 Files selected for processing (1)
  • scripts/package-build/linux-kernel/config/x86/vyos_defconfig
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • ansible/ansible (manual)
📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: codeql-analysis-call / Analyze (python)
  • GitHub Check: Mergify Merge Queue
  • GitHub Check: Mergify Merge Protections
  • GitHub Check: Summary
🧰 Additional context used
🔍 Remote MCP

Relevant PR context for T9138

  • T9138 is titled “Enable support for Microsoft MANA NIC drivers” and is currently Open with High priority. It is labeled as a feature and marked compatible for breaking-change status. citevyos.dev/maniphest-get
  • The task description says Microsoft Azure uses the MANA paravirtual network device, and the driver should be included in the kernel build because it appears required for Azure images. citevyos.dev/maniphest-get
  • The task is filed under VyOS Rolling (vyos_rolling). citevyos.dev/project-get
  • There are no comments on the task. citevyos.dev/maniphest-comments
🔇 Additional comments (1)
scripts/package-build/linux-kernel/config/x86/vyos_defconfig (1)

1767-1767: LGTM!

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added support for Microsoft MANA network hardware through the Linux kernel.

Walkthrough

Changes

Microsoft MANA driver

Layer / File(s) Summary
Kernel driver configuration
scripts/package-build/linux-kernel/config/x86/vyos_defconfig		 Adds CONFIG_MICROSOFT_MANA=m at line 1767, building the Microsoft MANA network driver as a loadable module.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects enabling the Microsoft MANA NIC driver in scripts/package-build/linux-kernel/config/x86/vyos_defconfig.
Description check ✅ Passed The description is directly related to the change, explaining the MANA module enablement and its x86-only support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the rolling label Jul 28, 2026
sever-sever
sever-sever approved these changes Jul 28, 2026
View reviewed changes

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the Microsoft MANA Kernel module

@mergify

mergify Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@dmbaturin
dmbaturin merged commit c2544eb into vyos:rolling Jul 28, 2026
11 checks passed
@vyos-bot vyos-bot Bot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sever-sever sever-sever sever-sever approved these changes

Assignees

@dmbaturin dmbaturin

Labels

mirror-completed rolling

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmbaturin @sever-sever